graph()/make_graph() error in rev deps

[maelle]

Taking part of the concerns of #970 to here.

In revdeps such as cran/BASiNETEntropy we see the error

Error in make_graph(edges = edges, n = n, isolates = isolates, directed = directed,  : 
  'simplify' should only be used for graph literals

for code such as graph(edges = edgestofilter[[t]], directed = FALSE)

Should the default value of the simplify argument (which is TRUE for both graph() and make_graph()) be changed? What about graph.famous()?

I wonder why the error didn't happen before.

[maelle]

oooh that's due to how we pass parameters of the call to graph(), to make_graph()!

[maelle]

preparing a PR. I see it's also problematic to pass both dir and directed.

[maelle]

maelle#5

[github-actions]

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.