Skip to content

chore: Fix drift after code generation#1278

Merged
aviator-app[bot] merged 1 commit intomainfrom
b-makefile
Mar 2, 2024
Merged

chore: Fix drift after code generation#1278
aviator-app[bot] merged 1 commit intomainfrom
b-makefile

Conversation

@krlmlr
Copy link
Copy Markdown
Contributor

@krlmlr krlmlr commented Mar 2, 2024

No description provided.

@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app Bot commented Mar 2, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@szhorvat
Copy link
Copy Markdown
Member

szhorvat commented Mar 2, 2024

Would it be possible to not make Docker mandatory for local development? I promise not to commit anything that didn't go through the standard process, but it'd be good to not enforce such a heavy dependency ..

@aviator-app aviator-app Bot merged commit a000c0d into main Mar 2, 2024
@aviator-app aviator-app Bot deleted the b-makefile branch March 2, 2024 20:55
@krlmlr
Copy link
Copy Markdown
Contributor Author

krlmlr commented Mar 3, 2024

One option would be to change the core to include the generated files. I see that this only shifts this problem, but then it becomes Somebody Else's. Docker is my way of dealing with it.

How can we implement it in a way that the default would be to run with Docker, but that the targets that require Docker can be omitted if needed?

@szhorvat
Copy link
Copy Markdown
Member

szhorvat commented Mar 3, 2024

In this setup, if the DOCKER variable is empty, we're back to the original setup. Is this correct?

Perhaps an environment variable could control if DOCKER is set, so SKIP_DOCKER=1 make -f Makefile-cigraph would not use Docker?

@krlmlr
Copy link
Copy Markdown
Contributor Author

krlmlr commented Mar 4, 2024

I'd prefer IGRAPH_SKIP_DOCKER, but yes, that would do it.

Or, my preferred way, not run flex and bison here at all, to avoid dealing with this in Python and Mathematica, too. Remember, the issue is the drift that occurs from different versions of these tools, which is hard to control. If there was a code owner for the files, they would be responsible for updating the generated code in Git, and could do this differently.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants