Conversation
Current Aviator status
This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
szhorvat
left a comment
There was a problem hiding this comment.
This just renames father to parent, right? I don't think my review is needed here (I wanted to do this for a long time).
|
This way you saw it's not even a breaking change 😸 |
|
Running checks now. |
|
@Antonov548: can you please resolve the merge conflicts in |
|
Resolved conflicts. |
|
I quickly "resolved the conflict" with the goal to then really fix it by running tests locally. Now I cannot load the package any more?! |
|
Do you need |
|
I think we could merge this. |
Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
|
I guess we can merge? |
bfs() and dfs()"parent" instead of "father" in bfs() and dfs()
|
Thanks! |
Fix #880
It's not breaking anything as the functions still also return the "father" field.