Skip to content

chore: use "parent" instead of "father" in bfs() and dfs()#1523

Merged
krlmlr merged 14 commits intomainfrom
parent
Mar 6, 2025
Merged

chore: use "parent" instead of "father" in bfs() and dfs()#1523
krlmlr merged 14 commits intomainfrom
parent

Conversation

@maelle
Copy link
Copy Markdown
Contributor

@maelle maelle commented Sep 23, 2024

Fix #880

It's not breaking anything as the functions still also return the "father" field.

@maelle maelle requested a review from szhorvat September 23, 2024 13:44
@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app Bot commented Sep 23, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Comment thread R/structural.properties.R
@maelle maelle added the lifecycle Deprecating old APIs label Sep 23, 2024
Copy link
Copy Markdown
Member

@szhorvat szhorvat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just renames father to parent, right? I don't think my review is needed here (I wanted to do this for a long time).

@maelle
Copy link
Copy Markdown
Contributor Author

maelle commented Sep 24, 2024

This way you saw it's not even a breaking change 😸

Copy link
Copy Markdown
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread R/structural.properties.R Outdated
Comment thread R/structural.properties.R
Comment thread R/structural.properties.R Outdated
Comment thread R/structural.properties.R Outdated
Comment thread tests/testthat/test-structural.properties.R
@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Nov 28, 2024

Running checks now.

@maelle
Copy link
Copy Markdown
Contributor Author

maelle commented Dec 3, 2024

mhahsler/pomdp#18

@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Jan 9, 2025

@Antonov548: can you please resolve the merge conflicts in src/rin*.c ?

@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Jan 9, 2025

Resolved conflicts.

@maelle
Copy link
Copy Markdown
Contributor Author

maelle commented Feb 13, 2025

I quickly "resolved the conflict" with the goal to then really fix it by running tests locally.

Now I cannot load the package any more?!

@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Feb 13, 2025

Do you need git clean -fdx src ?

@maelle
Copy link
Copy Markdown
Contributor Author

maelle commented Feb 19, 2025

I think we could merge this.

Copy link
Copy Markdown
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Comment thread R/structural.properties.R Outdated
Comment thread R/structural.properties.R Outdated
maelle and others added 2 commits March 6, 2025 10:08
Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
@maelle
Copy link
Copy Markdown
Contributor Author

maelle commented Mar 6, 2025

I guess we can merge?

@krlmlr krlmlr changed the title chore: use 'parent' instead of 'father' in bfs() and dfs() chore: use "parent" instead of "father" in bfs() and dfs() Mar 6, 2025
@krlmlr krlmlr merged commit d9ddf30 into main Mar 6, 2025
@krlmlr krlmlr deleted the parent branch March 6, 2025 10:01
@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Mar 6, 2025

Thanks!

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use 'parent' instead of 'father'

3 participants