refactor: removed for loops from get.incidence.dense() (#1483)#1655
Merged
krlmlr merged 2 commits intoigraph:mainfrom Jan 14, 2025
Merged
refactor: removed for loops from get.incidence.dense() (#1483)#1655krlmlr merged 2 commits intoigraph:mainfrom
for loops from get.incidence.dense() (#1483)#1655krlmlr merged 2 commits intoigraph:mainfrom
Conversation
Contributor
Current Aviator status
This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
krlmlr
approved these changes
Jan 14, 2025
| @@ -887,18 +886,22 @@ get.incidence.dense <- function(graph, types, names, attr) { | |||
| res <- matrix(0, n1, n2) | |||
Contributor
There was a problem hiding this comment.
What happens with non-numeric attributes?
krlmlr
changed the title
for loops from get.incidence.dense() (#1483)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes (nested) for loops
get.incidence.dense()whenattr != NULL(cherry picked commits from #1518)