Skip to content

refactor: one less tmp use case #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maelle merged 1 commit into from
Feb 27, 2025
Merged

refactor: one less tmp use case #1715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions R/plot.common.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,11 +556,18 @@ i.get.arrow.mode <- function(graph, arrow.mode = NULL) {
}

if (is.character(arrow.mode)) {
tmp <- numeric(length(arrow.mode))
tmp[arrow.mode %in% c("<", "<-")] <- 1
tmp[arrow.mode %in% c(">", "->")] <- 2
tmp[arrow.mode %in% c("<>", "<->")] <- 3
arrow.mode <- tmp
arrow.mode <- map_dbl(
arrow.mode,
\(x) switch(
x,
"<" = 1,
Copy link
Copy Markdown
Contributor Author

@maelle maelle Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be the first time I find vertical alignment useful 😸

"<-" = 1,
">" = 2,
"->" = 2,
"<>" = 3,
"<->" = 3
)
)
}

if (is.null(arrow.mode)) {
Expand Down