Skip to content

fix: Fix alpha_centrality() crash when weights is a custom attribute name #2403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krlmlr merged 4 commits into from
Oct 28, 2025
Merged

fix: Fix alpha_centrality() crash when weights is a custom attribute name #2403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc25d3a
Initial plan
Copilot Oct 26, 2025
040c125
Initial exploration of alpha_centrality bug
Copilot Oct 26, 2025
836af64
Fix `alpha_centrality()` crash with custom weight attributes
Copilot Oct 26, 2025
4153c79
Merge branch 'main' into copilot/fix-alpha-centrality-crash
krlmlr Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions R/centrality.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2018,7 +2018,7 @@ alpha.centrality.dense <- function(
attr <- NULL
} else if (is.character(weights) && length(weights) == 1) {
## name of an edge attribute, nothing to do
attr <- "weight"
attr <- weights
} else if (any(!is.na(weights))) {
## weights != NULL and weights != rep(NA, x)
graph <- set_edge_attr(graph, "weight", value = as.numeric(weights))
Expand Down Expand Up @@ -2065,7 +2065,7 @@ alpha.centrality.sparse <- function(
attr <- NULL
} else if (is.character(weights) && length(weights) == 1) {
## name of an edge attribute, nothing to do
attr <- "weight"
attr <- weights
} else if (any(!is.na(weights))) {
## weights != NULL and weights != rep(NA, x)
graph <- set_edge_attr(graph, "weight", value = as.numeric(weights))
Expand Down
16 changes: 16 additions & 0 deletions tests/testthat/test-centrality.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,6 +658,22 @@ test_that("weighted sparse alpha_centrality() works", {
expect_equal(ac3, c(vcount(star), 1, 1, 1, 1, 1, 1, 1, 1, 1))
})

test_that("alpha_centrality() works with custom weight attribute names", {
star <- make_star(10)
E(star)$myweight <- sample(ecount(star))

# Test sparse version with custom attribute name
ac_sparse <- alpha_centrality(star, weights = "myweight", sparse = TRUE)
expect_equal(ac_sparse, c(46, 1, 1, 1, 1, 1, 1, 1, 1, 1))

# Test dense version with custom attribute name
ac_dense <- alpha_centrality(star, weights = "myweight", sparse = FALSE)
expect_equal(ac_dense, c(46, 1, 1, 1, 1, 1, 1, 1, 1, 1))

# Ensure both versions give the same result
expect_equal(ac_sparse, ac_dense)
})

test_that("undirected alpha_centrality() works, #653", {
g <- make_ring(10)

Expand Down
Loading