Open
Conversation
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add make_hypercube function to expose igraph_hypercube
Add Oct 26, 2025
make_hypercube()
krlmlr
requested changes
Nov 1, 2025
| #' print_all(make_hypercube(4)) | ||
| #' @cdocs igraph_hypercube | ||
| make_hypercube <- function(n, directed = FALSE) { | ||
| on.exit(.Call(R_igraph_finalizer)) |
Contributor
There was a problem hiding this comment.
Suggested change
| on.exit(.Call(R_igraph_finalizer)) |
Contributor
Author
There was a problem hiding this comment.
Removed the on.exit(.Call(R_igraph_finalizer)) line in cd7ad26. This is now handled by the autogenerated hypercube_impl() function, consistent with other recently added functions like make_circulant().
…rcube-function # Conflicts: # man/make_graph.Rd
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Contributor
Author
Merged main and updated the implementation to follow the new guidelines in AGENTS.md in commit cd7ad26:
All checks pass: Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
krlmlr
approved these changes
Nov 1, 2025
Contributor
|
@schochastics: When good, please merge this. Rough workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on.exit(.Call(R_igraph_finalizer))line (handled by_implfunction)r lifecycle::badge("experimental")@concept hypercubefor pkgdown reference indexhypercube_impl()Original prompt
make_hypercube()#1389✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.