Skip to content

docs: replace graph() with make_graph() in examples#738

Merged
krlmlr merged 1 commit intoigraph:mainfrom
maelle:bye-graph()
Mar 30, 2023
Merged

docs: replace graph() with make_graph() in examples#738
krlmlr merged 1 commit intoigraph:mainfrom
maelle:bye-graph()

Conversation

@maelle
Copy link
Copy Markdown
Contributor

@maelle maelle commented Mar 28, 2023

Fix #736

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 28, 2023

Codecov Report

Merging #738 (9dfb4c8) into main (33c3376) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

❗ Current head 9dfb4c8 differs from pull request most recent head 9a53039. Consider uploading reports for the commit 9a53039 to get more accurate results

@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
- Coverage   53.93%   53.93%   -0.01%     
==========================================
  Files         357      357              
  Lines       73282    73281       -1     
==========================================
- Hits        39526    39523       -3     
- Misses      33756    33758       +2     
Impacted Files Coverage Δ
R/attributes.R 78.00% <ø> (ø)
R/centrality.R 74.75% <ø> (ø)
R/centralization.R 82.60% <ø> (ø)
R/conversion.R 73.91% <ø> (ø)
R/flow.R 79.13% <ø> (ø)
R/incidence.R 24.29% <0.00%> (ø)
R/iterators.R 91.68% <ø> (ø)
R/plot.common.R 64.63% <ø> (ø)
R/simple.R 85.71% <ø> (ø)
R/structural.properties.R 85.96% <ø> (ø)
... and 4 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ntamas
Copy link
Copy Markdown
Member

ntamas commented Mar 28, 2023

LGTM. 👍

@maelle
Copy link
Copy Markdown
Contributor Author

maelle commented Mar 30, 2023

what's the policy on merging, does this need another review? 😇

@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Mar 30, 2023

I'll take a closer look at my igraph inbox later today. 🌋

@ntamas
Copy link
Copy Markdown
Member

ntamas commented Mar 30, 2023

No, it's just unclear whether I can pull the trigger on it or we are waiting for @krlmlr :)

@krlmlr krlmlr changed the title refactor: replace graph() with make_graph() docs: replace graph() with make_graph() in examples Mar 30, 2023
@krlmlr krlmlr merged commit 79ea356 into igraph:main Mar 30, 2023
@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Mar 30, 2023

Thanks!

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deprecation loop

3 participants