Skip to content

Re-add failing test#806

Closed
krlmlr wants to merge 4 commits intomainfrom
b-ring-snapshot
Closed

Re-add failing test#806
krlmlr wants to merge 4 commits intomainfrom
b-ring-snapshot

Conversation

@krlmlr
Copy link
Copy Markdown
Contributor

@krlmlr krlmlr commented May 21, 2023

This reverts commit 84fb514.

Follow-up to #805.

This reverts commit 84fb514.
@krlmlr
Copy link
Copy Markdown
Contributor Author

krlmlr commented May 21, 2023

@Antonov548: Very weird. I tested on GitPod in Ubuntu 20.04 and also in a Docker container in 22.04, to no avail.

Can you perhaps put together a Dockerfile that shows the problem?

Some plotting tests now also start to fail in the main branch.

@Antonov548
Copy link
Copy Markdown
Contributor

ery weird. I tested on GitPod in Ubuntu 20.04 and also in a Docker container in 22.04, to no avail.

Can you perhaps put together a Dockerfile that shows the problem?

Some plotting tests now also start to fail in the main branch.

It also depending on the order of running tests or on amount of tests which is running. Because if I run this tests only be one I can't reproduce issue it at all.

@Antonov548
Copy link
Copy Markdown
Contributor

I can confirm that problem is in igraph_opt. As I mentioned it's only reproducible when all tests are running which setups this options in different order.

In function print.igraph option print.full which is sometimes FALSE for the test which is failing. As result it doesn't print edges. Maybe we need to expicit specify option print.full in this test.

@krlmlr
Copy link
Copy Markdown
Contributor Author

krlmlr commented May 22, 2023

Interesting. I've opened #809 to observe what happens to that option in the snapshot test. Let's keep this open until we fully understand the problem.

@krlmlr
Copy link
Copy Markdown
Contributor Author

krlmlr commented May 28, 2023

Now in #809.

@krlmlr krlmlr closed this May 28, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants