docs: fix use of deprecated functions in examples#827
Conversation
|
The test failure actually appears on main too. 🤔 |
|
Very nice that this could be partly automated! I didn't realise that we marked neighborhood() as a deprecated alias of ego(). "Ego" is a very social science centric description of the concept and IMO should not be the default name in a general purpose network analysis package. Perhaps it would be better to keep both names as non-deprecated? What do you think @ntamas ? For this PR, let's keep neighborhood() as is (not replace by ego()) and merge. |
There was a problem hiding this comment.
So just revert this single modification and then merge
This was a decision made by Gábor a long time ago and I kinda disagree with it. I'd un-deprecate |
Fix #825
@szhorvat This was semi-automatic: I automatically found calls to deprecated functions (only those from
R7zzz-deprecate.Rthough) then replaced them manually.@krlmlr Should this script stay in the package?