refactor: {lifecycle} instead of current deprecations#984
refactor: {lifecycle} instead of current deprecations#984maelle wants to merge 48 commits intoigraph:mainfrom
Conversation
Current Aviator status
This PR was closed without merging. If you still want to merge this PR, re-open it. See the real-time status of this PR on the Aviator webapp. Use the Aviator Chrome Extension to see the status of your PR within GitHub.
|
| @@ -0,0 +1,29 @@ | |||
|
|
|||
| # IGraph R package | |||
There was a problem hiding this comment.
I had to rename it so it'd be loaded first! 🤯
I needed the deprecated() calls to live inside the corresponding scripts otherwise later I couldn't have commits that corresponded to modifying one single R script and running document().
| @@ -0,0 +1,348 @@ | |||
| # parse script ---- | |||
There was a problem hiding this comment.
it wasn't directly sourced(), I ran it partly line by line and had to fix some Git mistakes I made, but it's a rough guide...
aviator-app
Bot
force-pushed
the
zzz-smarter
branch
10 times, most recently
from
1c8c60c to
766eaf9
Compare
refactor: start improving script improve script better script better script improve script
aviator-app
Bot
force-pushed
the
zzz-smarter
branch
from
766eaf9 to
d388a4a
Compare
krlmlr
left a comment
krlmlr
left a comment
There was a problem hiding this comment.
Thanks! I like how we now can cherry-pick changes.
I saw issues with the spacing, and 1.6.0 is out already. Can you please regenerate?
| get.edge.attribute <- function(graph , name , index = E(graph)) { # nocov start | ||
| lifecycle::deprecate_soft("1.6.0", "get.edge.attribute()", "edge_attr()") |
There was a problem hiding this comment.
| get.edge.attribute <- function(graph , name , index = E(graph)) { # nocov start | |
| lifecycle::deprecate_soft("1.6.0", "get.edge.attribute()", "edge_attr()") | |
| get.edge.attribute <- function(graph, name, index = E(graph)) { # nocov start | |
| lifecycle::deprecate_soft("2.0.0", "get.edge.attribute()", "edge_attr()") |
| #' @inheritParams graph_from_adjacency_matrix | ||
| #' @keywords internal | ||
| #' @export | ||
| graph.adjacency <- function(adjmatrix , mode = c("directed","undirected","max","min","upper","lower","plus") , weighted = NULL , diag = TRUE , add.colnames = NULL , add.rownames = NA) { # nocov start |
There was a problem hiding this comment.
| graph.adjacency <- function(adjmatrix , mode = c("directed","undirected","max","min","upper","lower","plus") , weighted = NULL , diag = TRUE , add.colnames = NULL , add.rownames = NA) { # nocov start | |
| graph.adjacency <- function(adjmatrix, mode = c("directed", "undirected", "max", "min", "upper", "lower", "plus"), weighted = NULL, diag = TRUE, add.colnames = NULL, add.rownames = NA) { # nocov start |
|
(I'll open a new PR) |
2 participants
No description provided.