Fix Dist::Zilla PkgVersion "no blank line" warnings#24
Open
paultcochrane wants to merge 1 commit into
Open
Conversation
When running the tests via `dzil test`, I found that the `Dist::Zilla` plugin `PkgVersion` gave several warnings like this: ``` [@DOY/PkgVersion] no blank line for $VERSION after package OX statement in lib/OX.pm line 1 ``` What this means is that `PkgVersion` expects an empty line after the `package` statement in each module file. This change adds this blank line to all of the affected files, hence removing the warnings and hence the distraction when running the test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the tests via
dzil test, I found that theDist::ZillapluginPkgVersiongave several warnings like this:What this means is that
PkgVersionexpects an empty line after thepackagestatement in each module file.This change adds this blank line to all of the affected files, hence removing the warnings and hence the distraction when running the test suite.
This pull request is submitted in the hope that it is useful. If you want anything changed, please let me know and I'll be more than happy to update and resubmit as necessary.