Skip to content

Relaxing dependencies to work with hf smolagents#165

Closed
galleon wants to merge 1 commit intoilluin-tech:mainfrom
galleon:relax/dependencies
Closed

Relaxing dependencies to work with hf smolagents#165
galleon wants to merge 1 commit intoilluin-tech:mainfrom
galleon:relax/dependencies

Conversation

@galleon
Copy link
Copy Markdown

@galleon galleon commented Jan 8, 2025

Fix #164
Tests are running fine

@ManuelFay
Copy link
Copy Markdown
Collaborator

ManuelFay commented Jan 8, 2025

As is we can't merge, there was a training discrepancy with numpy 2, and we still want to bound transformers version etc.
Best is probably that Tony or I take care of it.
Pretty sure PEFT also is a bit different although we did change what we were using !
This requires a bit more extensive testing for sure though

@galleon
Copy link
Copy Markdown
Author

galleon commented Jan 8, 2025

I agree that more tests are probably needed, but in my opinion, capping versions often causes more problems than it solves. I’d like to fine-tune my own version of ColQwen2—would that be acceptable as part of the additional tests? Of course, I’m also fine with Tony or yourself handling the issue if that works better.

@tonywu71
Copy link
Copy Markdown
Contributor

tonywu71 commented Jan 9, 2025

Duplicate of #166.

@tonywu71 tonywu71 closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not working with smolagents

3 participants