Adding optional dataset_name arg to index() method#138
Merged
QuentinJGMace merged 3 commits intoilluin-tech:mainfrom Mar 25, 2026
Merged
Adding optional dataset_name arg to index() method#138QuentinJGMace merged 3 commits intoilluin-tech:mainfrom
QuentinJGMace merged 3 commits intoilluin-tech:mainfrom
Conversation
gabrielspmoreira
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
dataset_namearg to theindex()method of retrieval pipelines.The
dataset_nameis useful to implement things like embedding caching, if you are interested for example on evaluating rerankers or agentic retrieval pipelines (like this AgenticRetrievalPipeline (doc)) without having to embed the whole corpus on index() method for every evaluation.