Conversation
Replace u64::is_multiple_of() (stabilized 1.87) with count % skip != 0 in DebouncedTimeout. The enough crate itself already compiled on 1.85; this was the only blocker in almost-enough. Update CI matrix and workspace rust-version to match.
- cargo-semver-checks: catch accidental breaking changes - cargo-hack feature powerset: verify all feature combinations compile - cargo-deny: license and advisory audit (with deny.toml) - Miri: soundness checking for enough-ffi unsafe code - WASM build: verify wasm32-unknown-unknown builds for no_std crates - macOS Intel: add macos-26-intel to cross-platform matrix - MSRV: test full workspace (1.85 is above all dev-dep floors) - README: update MSRV badge to 1.85
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=======================================
Coverage 97.85% 97.86%
=======================================
Files 16 16
Lines 2336 2339 +3
=======================================
+ Hits 2286 2289 +3
Misses 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Miri: replace integer-to-pointer casts in enough-ffi tests with a SendPtr wrapper that preserves provenance. The disjoint field capture in edition 2024 requires a method accessor (.ptr()) so the closure captures the Send wrapper, not the raw pointer field. MSRV: criterion 0.8 requires Rust 1.86, so MSRV job tests per-crate to avoid pulling in bench dev-deps.
Port stop_check benchmark from criterion to zenbench. The other two benchmarks (stop_check_zen, debounced_timeout) already used zenbench. With criterion removed, all dev-deps support Rust 1.85, so MSRV CI can use cargo test --workspace instead of per-crate testing.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
u64::is_multiple_of()(stabilized in 1.87) withcount % skip != 0inDebouncedTimeoutrust-versionto 1.85 (edition 2024 floor)enoughalready compiled on 1.85; theis_multiple_ofcall inalmost-enoughwas the only blocker.Test plan
cargo test --workspacepasses locally (326 tests)cargo clippycleancargo fmtclean