Add testing file and formatting changes #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Markdown file for testing the shading/flatfield method. Instructions at the top
Add period to docstring, change from double to float and remove redundant "the".
ehrenfeu
requested changes
Aug 9, 2024
Member
ehrenfeu
left a comment
ehrenfeu
left a comment
There was a problem hiding this comment.
Hi @rohangirishrao, could you have a look if you can now see my reviewing comments?
Removed one blank line and added one before each section heading
ehrenfeu
approved these changes
Aug 9, 2024
Member
ehrenfeu
left a comment
ehrenfeu
left a comment
There was a problem hiding this comment.
Thanks, good to merge now! 🔀 ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markdown testing file for flatfield correction and a few docstring changes to conform to convention. Additionally, removed some redundant comments.