Skip to content

fix: SetCookieJarFactory factory return http.CookieJar #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaylee595 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

fix: SetCookieJarFactory factory return http.CookieJar #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ type Client struct {
AllowGetMethodPayload bool
*Transport
digestAuth *digestAuth
cookiejarFactory func() *cookiejar.Jar
cookiejarFactory func() http.CookieJar
trace bool
disableAutoReadResponse bool
commonErrorType reflect.Type
Expand Down Expand Up @@ -1557,7 +1557,7 @@ func (c *Client) Clone() *Client {
return &cc
}

func memoryCookieJarFactory() *cookiejar.Jar {
func memoryCookieJarFactory() http.CookieJar {
jar, _ := cookiejar.New(&cookiejar.Options{PublicSuffixList: publicsuffix.List})
return jar
}
Expand Down Expand Up @@ -1604,7 +1604,7 @@ func C() *Client {
// cookie jar that store cookies for underlying `http.Client`. After client clone,
// the cookie jar of the new client will also be regenerated using this factory
// function.
func (c *Client) SetCookieJarFactory(factory func() *cookiejar.Jar) *Client {
func (c *Client) SetCookieJarFactory(factory func() http.CookieJar) *Client {
c.cookiejarFactory = factory
c.initCookieJar()
return c
Expand Down