Updates to Order Detail and List Views#70
Conversation
updated front-end for about half of order detail view, currently editing order card files to fit the new figma files
There was a problem hiding this comment.
This looks great so far! The only thing I see is that the order details page looks a bit hardcoded right now, do you think you could make the size of the containers scale depending on screen width (maybe make the left containers expand to 70% of the width and the right container expand to 30%, then just have some padding in the parent container)? Also do you have ESLint installed? It looks like it's failing the code check because of that.
| height: 47px; | ||
| width: 47px; | ||
| width: 172px; | ||
| height: 64px; |
There was a problem hiding this comment.
Usually for buttons, try to avoid hardcoding the size, just base the size of the button off of the text inside with padding around it.
| padding: var(--small-spacer) var(--medium-spacer); | ||
| gap: var(--small-spacer); | ||
|
|
||
| margin-left: 300px; |
There was a problem hiding this comment.
I assume this space is just for the sidebar, but in the future, you won't need this so you can honestly just assume your page takes up 100% of its parent.
Update to Order Cards and list page to look at all cards
2 participants
updated front-end for about half of order detail view, currently editing order card files to fit the new figma files