Add tag_axes
#171
Merged
Add tag_axes
#171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inducer
commented
Jun 10, 2022
Comment on lines
+483
to
+498
| def tag_axes( | ||
| actx: ArrayContext, | ||
| dim_to_tags: Mapping[int, ToTagSetConvertible], | ||
| ary: ArrayT) -> ArrayT: |
Owner
Author
There was a problem hiding this comment.
Note that I've changed the argument order here, compared to the original in inducer/meshmode#284. The rationale for this is that the array might be a complicated expression, and so I find it easiest if it comes last (because you don't have to remember that you still "owe" otherwise simpler arguments of tag_axes. Also for consistency with tag_axis.
2 tasks
Owner
Author
|
Unlike my earlier, misplaced comment suggested, this should be ready for a look. Sorry about the confusion! |
Co-authored-by: Kaushik Kulkarni <kaushikcfd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stolen from inducer/meshmode#284.