Remove Toolchain::get_dependencies extra entries #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm using the `icx` compiler from OneAPI to compile OpenMP offload code. The following command used to query dependencies: `icx -M -O3 -g -fPIC -Wall -std=c99 -qopenmp -fopenmp-targets=spir64 /home/u83311/tmp/devito-jitcache-uid85311/260030861f24c1e2bc347afa986d9632be371ca9.c` returns the expected headers, as well as lines such as: `# __CLANG_OFFLOAD_BUNDLE____START__ openmp-spir64` which then later lead to issues because these are not files. I am not sure, what would be the ideal solution, perhaps filter out lines beginning with `#`?
inducer
reviewed
Feb 8, 2022
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Owner
|
Thanks! |
Owner
|
(Something's still unhappy, could you take a look?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the
icxcompiler from OneAPI to compile OpenMP offload code. The following command used to query dependencies:icx -M -O3 -g -fPIC -Wall -std=c99 -qopenmp -fopenmp-targets=spir64 /home/u83311/tmp/devito-jitcache-uid85311/260030861f24c1e2bc347afa986d9632be371ca9.creturns the expected headers, as well as lines such as:
# __CLANG_OFFLOAD_BUNDLE____START__ openmp-spir64which then later lead to issues because these are not files. I am not sure, what would be the ideal solution, perhaps filter out lines beginning with
#?