Skip to content

Conversation

@alexfikl
Copy link
Contributor

Went ahead and added loopy too, so that this gets some real world usage.

@inducer
Copy link
Owner

inducer commented Apr 28, 2022

codepy.toolchain.ToolchainGuessError: unknown compiler

I guess there's your answer. No mac compatibility worth speaking of. That makes your job in #28 easier. :)

The loopy downstream seems worth having though.

@alexfikl
Copy link
Contributor Author

alexfikl commented Apr 28, 2022

codepy.toolchain.ToolchainGuessError: unknown compiler

I guess there's your answer. No mac compatibility worth speaking of. That makes your job in #28 easier. :)

The loopy downstream seems worth having though.

There's some support in here
https://github.com/inducer/codepy/blob/main/codepy/toolchain.py#L461-L473
but not sure if that applies at all to newer versions. Maybe it needs a conda install like pyopnecl to get some compilers?

@inducer
Copy link
Owner

inducer commented Apr 28, 2022

There's some support in here

It's already broken, it was never tested, and nobody seems to care. I'd rather just delete that code. :)

@alexfikl
Copy link
Contributor Author

There's some support in here

It's already broken, it was never tested, and nobody seems to care. I'd rather just delete that code. :)

And it's gone! 🌮

Kept the loopy CI like you said though.

@alexfikl alexfikl changed the title Add ci for macOS and loopy downstream Remove support for macOS Apr 28, 2022
@alexfikl alexfikl changed the title Remove support for macOS Remove support for macOS (unmaintained) Apr 28, 2022
@alexfikl
Copy link
Contributor Author

alexfikl commented Apr 28, 2022

For reference (https://trac.macports.org/wiki/XcodeVersionInfo) it seems like the version string went from

Apple LLVM version 10.0.1 (clang-1001.0.46.4) 

to

Apple clang version 11.0.0 (clang-1100.0.33.8) 

at some point, so the check in here stopped working.

EDIT: just tried extending that check a bit, but it failed to compile a module, so more work is likely needed.

@inducer inducer merged commit 8eb30b4 into inducer:main Apr 28, 2022
@inducer
Copy link
Owner

inducer commented Apr 28, 2022

Thanks!

@alexfikl alexfikl deleted the beef-up-ci branch April 28, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants