Strictly type everything #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfikl
force-pushed
the
more-strict-mypy
branch
from
3e169cb to
0051b42
Compare
Contributor
Author
|
Hm, this seems to be installing |
Owner
|
I think it'd need a |
Contributor
Author
Yep, that worked nicely. Thanks! 😁 |
inducer
reviewed
Jan 9, 2025
Contributor
Author
There was a problem hiding this comment.
That was already turned on in #49. This PR just removes the ignores for the remaining files.
Owner
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds strict typing to the remaining modules as well and removes the ignore on
cgen, since that's strictly typed now too.