Tag axes of discretization-related arrays #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matt Smith <majosm@illinois.edu> Co-authored-by: Andreas Kloeckner <inform@tiker.net>
1 task
Co-authored-by: Matthias Diener <mdiener@illinois.edu> Co-authored-by: Andreas Kloeckner <inform@tiker.net>
Owner
Author
|
Thanks for taking a look, and for working on this in the first place! Took a final look, LGTM. Setting to merge, assuming it passes. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes #188 (in the form of kaushikcfd@3d184d5) and modernizes it for the merged form of inducer/meshmode#284, and adds two commits to help avoid things that are now deprecated. This also includes kaushikcfd@1d89eb2, because why not.
Empirically, with this hacked version of https://github.com/kaushikcfd/meshmode/commits/main, it is still capable of transforming mirgecom code.
Best read commit-by-commit.