Skip to content

Invalid python function name fix #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inducer merged 5 commits into from
Oct 20, 2021
Merged

Invalid python function name fix #69

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84748ba
fix macOS barvinok build
thisiscam Oct 3, 2021
dea1abb
Merge remote-tracking branch 'origin/main' into main
thisiscam Oct 17, 2021
30472e4
Merge remote-tracking branch 'origin/main' into main
thisiscam Oct 18, 2021
d176636
fix invalid python function name
thisiscam Oct 18, 2021
f93f38a
special casing for invalid py identifier
thisiscam Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions gen_wrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,11 @@ def on_directive_handle(self, directive, toks, ifpassthru, precedingtoks):
# {{{ FunctionData (includes parser)

class FunctionData:

INVALID_PY_IDENTIFIER_RENAMING_MAP = {
"2exp": "two_exp"
}

def __init__(self, include_dirs):
self.classes_to_methods = {}
self.include_dirs = include_dirs
Expand Down Expand Up @@ -656,6 +661,13 @@ def parse_decl(self, decl):
if name in PYTHON_RESERVED_WORDS:
name = name + "_"

name = self.INVALID_PY_IDENTIFIER_RENAMING_MAP.get(name, name)

if name[0].isdigit():
print(f"SKIP: {class_name} {name} "
"(unhandled invalid python identifier)")
return

if class_name == "options":
assert name.startswith("set_") or name.startswith("get_"), (name, c_name)
name = f"{name[:4]}option_{name[4:]}"
Expand Down