Conversation
…ally for now (previously were defined in schedule checking utils before this code was moved to independent branch)
…as defined in schedule checking utils before this code was moved to independent branch)
This was referenced Aug 5, 2021
…n domains (with _apply_identity_for_missing_map_dims func)
…rm map and inames domain
… the transform map and the inames in a domain
…s involving the mapped inames
… constraints involving the mapped inames
…tains some but not all mapped inames
Collaborator
Author
|
@inducer This is ready for you to look at. I haven't yet expressed |
inducer
reviewed
Aug 30, 2021
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Looking great, thanks! Just a few wrinkles, then this should be good to go.
update arg without copy in _find_and_rename_dim Co-authored-by: Andreas Klöckner <inform@tiker.net>
in map_domain, use <= instead of issubset Co-authored-by: Andreas Klöckner <inform@tiker.net>
…d_and_rename_dim into isl_helpers
… about functions defined in other branches
…s, and find_and_rename_dim
…ke it only accept a single dim type arg
… attribute in kernel; also clarify purpose of some tests
…d_errors run faster
…tize_loops() or constrain_loop_nesting()
jdsteve2
force-pushed
the
map-domain-transformation-v2
branch
from
332ebf5 to
6e1f1d9
Compare
Collaborator
Author
Thanks! I have ironed the wrinkles and it's ready for you when you get a chance. In case it helps, here's a diff of the changes since yesterday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
map_domaintransformation.This PR/branch is one of two parents of child PR/branch: Update dependencies during transformation
This PR/branch was moved here to independent, top-level PR/branch from old PR/branch: Add map_domain transformation.
Note that to keep these branches independent, some helper functions are defined in both branches.