Update type annotations in symbolic and function_interface #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

inducer merged 18 commits into inducer:main from alexfikl:type-function-interface

Nov 4, 2025

Contributor

alexfikl commented Oct 30, 2025

No description provided.

alexfikl marked this pull request as draft

October 30, 2025 11:39

alexfikl force-pushed the type-function-interface branch from 9bb62d6 to ab98e76 Compare

October 30, 2025 11:40

alexfikl commented

View reviewed changes

loopy/kernel/function_interface.py Show resolved Hide resolved

alexfikl force-pushed the type-function-interface branch from ab98e76 to 2ff1f20 Compare

October 30, 2025 11:47

alexfikl commented

View reviewed changes

loopy/kernel/function_interface.py Outdated Show resolved Hide resolved

alexfikl commented

View reviewed changes

loopy/kernel/function_interface.py Outdated Show resolved Hide resolved

alexfikl commented

View reviewed changes

loopy/symbolic.py Show resolved Hide resolved

alexfikl commented

View reviewed changes

loopy/symbolic.py Outdated Show resolved Hide resolved

alexfikl force-pushed the type-function-interface branch from 2ff1f20 to a0176f9 Compare

October 30, 2025 12:01

alexfikl commented

View reviewed changes

loopy/symbolic.py Show resolved Hide resolved

alexfikl force-pushed the type-function-interface branch from a0176f9 to 7466543 Compare

October 30, 2025 12:13

alexfikl commented

View reviewed changes

loopy/symbolic.py Show resolved Hide resolved

alexfikl commented

View reviewed changes

loopy/symbolic.py Show resolved Hide resolved

alexfikl marked this pull request as ready for review

October 30, 2025 12:20

inducer reviewed

View reviewed changes

Owner

inducer left a comment

Thanks!

loopy/kernel/function_interface.py Show resolved Hide resolved

loopy/kernel/function_interface.py Outdated Show resolved Hide resolved

loopy/symbolic.py Outdated Show resolved Hide resolved

loopy/symbolic.py Show resolved Hide resolved

loopy/symbolic.py Show resolved Hide resolved

alexfikl mentioned this pull request

Make Mapper.map_ methods take expr as positional only inducer/pymbolic#221

Merged

alexfikl force-pushed the type-function-interface branch 3 times, most recently from 15d13b0 to 7550b9a Compare

November 3, 2025 18:16

alexfikl added 9 commits

November 3, 2025 21:36


          feat(typing): update type annotations in symbolic

aab63ee


          feat: use more f-strings in symbolic

e849129


          docs: updates for symbolic

90c2c10


          feat(typing): improve typing in kernel.function_interface

6fc75d3


          feat(typing): add overloads for get_grid_size_upper_bounds

ca2b9ce


          feat: use more f-strings in function_interface

8f59b59


          docs: update some refs

a0db40e


          feat: remove unused par_dtypes

4cd9833


          feat: update InKernelCallable.emit_call types and docs

d1c8df5

alexfikl force-pushed the type-function-interface branch from 7550b9a to 07eb2ac Compare

November 3, 2025 19:36

inducer mentioned this pull request

EvaluationMapper: preserve Subscript inducer/pymbolic#224

Draft

inducer added 9 commits

November 4, 2025 13:38


          Add a TypeContext type alias

d0fb33c


          IdentityMapperMixin: separate out map_rule_argument

5b544ce


          LinearSubscript: index is arithmetic

955f6a6


          Code gen for SubArrayRef: handle empty subscript

6bdf67c

x-ref: inducer/pymbolic#224


          Code gen for expressions: more types

0ae2bcd


          Misc type fixes


          IdentityMapperMixin: positional-only expr

65df827


          Reduction code gen: fail for non-C targets

01e5054


          Update baseline

bff59f2

inducer force-pushed the type-function-interface branch from 07eb2ac to bff59f2 Compare

November 4, 2025 19:39

inducer enabled auto-merge (rebase)

November 4, 2025 19:54

Owner

inducer commented Nov 4, 2025

Thanks for working on this!

inducer merged commit 2ec9227 into inducer:main

17 checks passed

alexfikl deleted the type-function-interface branch

November 6, 2025 14:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet