Skip to content

Add unified dockerfile#221

Merged
rcvalerio merged 3 commits intodevfrom
rv-add-unified-dockerfile
Oct 22, 2025
Merged

Add unified dockerfile#221
rcvalerio merged 3 commits intodevfrom
rv-add-unified-dockerfile

Conversation

@rcvalerio
Copy link
Contributor

@rcvalerio rcvalerio commented Oct 21, 2025

This PR adds a new Dockerfile that allows launching the task-runner and file-tracker in the same container

@hpenedones this are the commands I used to test:

docker build -f Dockerfile -t task-runner-unified .
docker run -d --name task-runner-unified --network host --privileged --add-host host.docker.internal:host-gateway -e EXECUTER_IMAGES_DIR=/executer-images -e API_URL=$INDUCTIVA_API_URL -e USER_API_KEY=$INDUCTIVA_API_KEY -e MACHINE_GROUP_NAME=$MACHINE_GROUP_NAME -e HOST_NAME=${TASK_RUNNER_HOSTNAME:-${HOSTNAME}} -v workdir:/workdir -v $(pwd)/apptainer:/executer-images task-runner-unified
  • Should we include a Makefile rule and mention the unified image in the README.md? UPDATE: done
  • Should we push the task-runner-unified image to dockerhub? UPDATE: done

@hpenedones
Copy link

Thanks for this Rodrigo!
Yes, ideally we would push the task-runner-unified image to dockerhub, so that we can then experiment with launching both services from a single image.

@rcvalerio
Copy link
Contributor Author

Thanks for this Rodrigo! Yes, ideally we would push the task-runner-unified image to dockerhub, so that we can then experiment with launching both services from a single image.

Should we have a github action to push the image to dockerhub @bgregoinductiva ?

@bgregoinductiva
Copy link
Contributor

Thanks for this Rodrigo! Yes, ideally we would push the task-runner-unified image to dockerhub, so that we can then experiment with launching both services from a single image.

Should we have a github action to push the image to dockerhub @bgregoinductiva ?

Yes, please extend the current workflow.

Should we include a Makefile rule and mention the unified image in the README.md?

Please do this as well.

@rcvalerio
Copy link
Contributor Author

rcvalerio commented Oct 22, 2025

New changes:

  • Github action to push to dockerhub;
  • New makefile rule: make task-runner-unified-up;
  • Updated README.md

@rcvalerio rcvalerio merged commit 3e1d0d5 into dev Oct 22, 2025
1 check passed
@rcvalerio rcvalerio deleted the rv-add-unified-dockerfile branch October 22, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments