Skip to content

fix: gyp allows spaces in action names. ninja doesn't #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
refack wants to merge 2 commits into from
Closed

fix: gyp allows spaces in action names. ninja doesn't #31

refack wants to merge 2 commits into from

Conversation

@refack
Copy link
Contributor

@refack refack commented Feb 5, 2017

No description provided.

@refack
Copy link
Contributor Author

refack commented Feb 5, 2017

I added a counter so rule names don't get spurius suffixes.
(It was generates noise while I compare other changes)

@refack refack mentioned this pull request Feb 6, 2017
Closed
@refack
Copy link
Contributor Author

refack commented Feb 9, 2017

made obsolete by #33

@refack refack closed this Feb 9, 2017
@refack refack deleted the patch-1 branch February 15, 2017 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@refack