Skip to content

CI: Enable PipInstallSimple rule#200

Closed
jayvdb wants to merge 2 commits intoindygreg:mainfrom
jayvdb:ci-simple-rule
Closed

CI: Enable PipInstallSimple rule#200
jayvdb wants to merge 2 commits intoindygreg:mainfrom
jayvdb:ci-simple-rule

Conversation

@jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Nov 19, 2019 •
edited
Loading

Closes #206

@jayvdb jayvdb force-pushed the ci-simple-rule branch 2 times, most recently from 0445ca8 to 7804f11 Compare November 21, 2019 06:09
jayvdb
jayvdb commented Nov 23, 2019
View reviewed changes
@jayvdb jayvdb mentioned this pull request Nov 25, 2019
Open
@jayvdb
pyinterp.rs: Emit exitcode on exception in repl
89847c2 
Fixes indygreg#208
@jayvdb
CI: Enable PipInstallSimple rule
cff1d6a 
To simplify editing of the sample app Python code,
replace --python-code with stdin pipe of ci/pyapp.py

On Windows, replace %HOME% with %USERPROFILE%.

Fixes indygreg#206
@indygreg
Copy link
Owner

indygreg commented Nov 28, 2019

I manually applied these commits. I dropped the changes to refactor the CI to use a standalone file because I don't think it adds sufficient value to include.

Regarding CI, I would prefer for as much functionality as possible to be tested in cargo test. And if cargo test is not sufficient for command-line level tests, then we should establish a dedicated script to run that invokes pyoxidizer and test with that: I do not want low-level test code defined in YAML files because the CI configuration should not be the source of truth on how tests are defined and how to invoke them.

@indygreg indygreg closed this Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows CI built app problems

2 participants

@jayvdb @indygreg