specify kernel name when starting new kernel#4
Merged
ines merged 1 commit intoines:masterfrom Apr 10, 2019
Merged
Conversation
Owner
|
@amn41 Thanks, looks good! 👍 And yes, I think I just didn't realise the kernel type had to be passed into I'll merge this and try to get another release up on npm and not procrastinate on this. (No idea what it is, but I really hate JS/Node/npm packaging and publishing 😫 I tried to get a package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3 (at least insofar as I experienced this issue).
Steps to reproduce:
Create a juniper object:
Attempting to run this will result in a SytaxError because the kernel is python3 by virtue of the default kernel name. Applying this patch fixes the issue & the command executes correctly.
I re-used the
this.kernelTypeoption rather than introducing a new'name'option because as far as I can tell they are equivalent. Though there could be edge cases where these differ I'm just not aware of them.