mainRouteDetail fails to parse Bird output #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my setup, the code parsing the Bird output didn't work. To be honest, I am a little surprised by the fix, so please review and let me know what you think. Anyway, I studied the regular expressions and figured that the properties come out of the matches array in the order shown in my patch. Previous order was yielding broken results, with fields in incorrect places, etc. I also tried to cover the case of unreachable, unicast or blackhole routes (if branch in line 151), but cannot extensively test these.
Member
|
Hi @aduitsis - what version of Bird are you using? There may be issues with Bird v1.x and Birdseye v1.2. |
Contributor
Author
|
Hey @barryo! Definitely not version 2. We're still at version 1.x. Yes, it does look like an issue. If the patch can be of use to help with 1.x, we'd be very happy. |
Member
|
Cool. Can you use v1.1.4 with Bird v1 for now? I have a few patches / test bits of code myself to make v1.2 work with Bird v1 but it's tricky-ish to test. |
Contributor
Author
|
Sorry for the late reply, I'm specifically using 1.2 with a test Bird installation to install and test IXPManager 5. I use 1.1.x in production. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my setup, the code parsing the Bird output for a route detail didn't work. To be honest, I am a little surprised by the fix, so please review and let me know what you think.
Anyway, I studied the regular expressions and figured that the properties come out of the matches array in the order shown in my patch. Previous order was yielding broken results, with fields in incorrect places, etc.
I also tried to cover the case of unreachable, unicast or blackhole routes (if branch in line 151), but cannot extensively test these.