Skip to content
This repository was archived by the owner on Dec 6, 2023. It is now read-only.

fix(networking): dont stop an empty timer #1039

Merged
jamonholmgren merged 2 commits into from
May 12, 2022
Merged

fix(networking): dont stop an empty timer #1039

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91dc3e1
fix(networking): dont stop an empty timer
odjhey Jan 23, 2022
579c58e
fix(networking): use passed xhr when cache is empty
odjhey Jan 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/plugins/networking.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export default <ReactotronSubtype = ReactotronCore>(pluginConfig: NetworkingOpti

// fetch and clear the request data from the cache
const rid = xhr._trackingName
const cachedRequest = requestCache[rid] || {}
const cachedRequest = requestCache[rid] || { xhr }
requestCache[rid] = null

// assemble the request object
Expand Down Expand Up @@ -112,7 +112,7 @@ export default <ReactotronSubtype = ReactotronCore>(pluginConfig: NetworkingOpti
}

// send this off to Reactotron
;(reactotron as any).apiResponse(tronRequest, tronResponse, stopTimer()) // TODO: Fix
;(reactotron as any).apiResponse(tronRequest, tronResponse, stopTimer ? stopTimer() : null) // TODO: Fix
}

// can we use the real response?
Expand Down