feat(iac-647): added ml-logging-linter skill, improved logging rules#4
Open
feat(iac-647): added ml-logging-linter skill, improved logging rules#4
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new .claude skill for auditing JS/TS logging against Mojaloop standards, and updates the logging standards docs to better distinguish VERBOSE vs DEBUG usage and align DB attribute naming with the SQL logging standard.
Changes:
- Refines
standard/log_levels.mdguidance/examples around VERBOSE (flow tracing) vs DEBUG (data inspection) and updates DB attribute naming. - Updates
standard/best_practices.mdDB semantic convention attributes todb.system.name/db.query.text. - Introduces the
ml-logging-linterskill with full rules documentation and a runtime fallback quick reference.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| standard/log_levels.md | Updates log level guidance/examples (VERBOSE vs DEBUG) and DB attribute naming in examples. |
| standard/best_practices.md | Aligns the DB semantic conventions table with the SQL logging standard attribute names. |
| .claude/skills/ml-logging-linter/SKILL.md | Adds the skill definition and workflow for scanning JS/TS logging violations. |
| .claude/skills/ml-logging-linter/references/RULES.md | Adds detailed rule documentation, traceability, and examples for the logging linter. |
| .claude/skills/ml-logging-linter/references/rules-summary.md | Adds a condensed rule table to use when full rules can’t be read. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…rver.address/server.port and db.system.name Agent-Logs-Url: https://github.com/infitx-org/logging/sessions/59efd546-fd61-4800-8199-3bbd41824d53 Co-authored-by: geka-evk <16463615+geka-evk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.