Skip to content

Transaction monitor- dev #46

Open
jordan-modusbox wants to merge 9 commits intolatestfrom
transaction-monitor-2.0
Open

Transaction monitor- dev #46
jordan-modusbox wants to merge 9 commits intolatestfrom
transaction-monitor-2.0

Conversation

@jordan-modusbox
Copy link
Copy Markdown
Contributor

Adding screen shots back to Central Pane Elements
Editing lists on 4 partials in central pane elements

@jordan-modusbox jordan-modusbox requested a review from IanWhyte July 24, 2020 21:59
@IanWhyte IanWhyte marked this pull request as draft July 30, 2020 18:36
@IanWhyte IanWhyte marked this pull request as ready for review July 30, 2020 18:36
Comment thread portx/modules/ROOT/pages/_partials/documents-view.adoc Outdated
Copy link
Copy Markdown
Contributor

@IanWhyte IanWhyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I endeavored to provide an explanation for my editing choices, either in the form of a link to a section in Style Guide or in the Git comment itself. But if you have ay questions, for sure, let me know - editing is a team sport.


* The blue copy icon icon:plus-square-o[role="blue"] allows you to copy information to your clipboard
* The blue share icon icon:share[role="blue"] opens a detail pane that shows the complete message payload.
* *Document ID*- Unique copyable document identification.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best as a definition list - see https://docs.google.com/document/d/1aLM3e7ocmmuaC2deAycPScSzaRyf0KCIdWV4YftI-VY/edit?usp=sharing
If the appearance of a field in the pane is record-dependent, we should state that. It might be useful to create a table that shows which fields appear for which records; if you were to try that, the fields would have to be the rows (because there are so many), and the records the columns.


==== *Detail Pane Action Icons*

* The *blue copy icon* icon:plus-square-o[role="blue"] allows you to copy information to your clipboard
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Period at end (if the content of a bullet is a complete sentence, it always gets an ending period).


==== Buttons
==== *Buttons*
* A *Transaction* icon:exchange[] button will appear when a document is selected
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

==== Buttons
==== *Buttons*
* A *Transaction* icon:exchange[] button will appear when a document is selected
** This will take you to the xref:central-pane-elements#transactions-view[Transactions View] and highlight this specific document
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c/will take/takes/

Also, because you only have one bullet in each of these lists, you can (and should make this a single un-bulleted sentence. So:

A Transaction button appears when a document is selected; this takes you to the Transactions View and highlights this specific document.

See https://drive.google.com/a/modusbox.com/open?id=1aLM3e7ocmmuaC2deAycPScSzaRyf0KCIdWV4YftI-VY

. *To:* Who the transaction was going to
. *Date:* Date and time at which the error occurred
. *Error Code:* Code associated with the error
. *From-* Who the transaction came from
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best as a definition list - see
https://drive.google.com/file/d/1H8dLWGi-F8AllbBeLtGNWwmlaBTW3x54/view?usp=sharing and
https://docs.google.com/document/d/1aLM3e7ocmmuaC2deAycPScSzaRyf0KCIdWV4YftI-VY/edit?usp=sharing

c/Who the transaction was going to/To whom the transaction was going/
c/Who the transaction came from/From whom the transaction came/
Best to avoid ending a sentence with a preposition: see https://docs.google.com/document/d/1HyhkDiMzD57DwDXa6R-HUd_f1weAfKKCwFh0RX57yEk/edit#heading=h.1clsts64j7pj
Also, when a pronoun is a direct or indirect object in a sentence, it takes the objective case.


Relationship:: Filter by the application or partner between which the transaction occurs.
* Choose the Partner or Application from the dropdown menu
* Choose the Partner or Application from the dropdown menu.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete bullet. So:
To filter by the application or partner between which the transaction occurs, choose the Partner or Application from the dropdown menu.

* The blue share icon icon:share[role="blue"] opens a detail page that shows the complete message payload.
==== *Detail Pane Action Icons*
* The *blue copy icon* icon:plus-square-o[role="blue"] allows you to copy information to your clipboard
* The *blue arrow icon* icon:share[role="blue"] opens a detail page that shows the complete message payload.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c/allows/enables/ - people prefer to be enabled more than to be allowed


==== Buttons
==== *Buttons*
* A *Transaction* icon:exchange[] button will appear when a transmission is selected
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

present tense (not future)

==== Buttons
==== *Buttons*
* A *Transaction* icon:exchange[] button will appear when a transmission is selected
** This will take you to the xref:central-pane-elements#transactions-view[Transactions View] and highlight this specific transmission
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use present tense

@@ -50,11 +62,11 @@ View::
* Partners
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under Custom Range, use def list

…egration/modusbox-docs into transaction-monitor-2.0

# Conflicts:
#	portx/modules/ROOT/pages/_partials/documents-view.adoc
#	portx/modules/ROOT/pages/_partials/errors-view.adoc
#	portx/modules/ROOT/pages/_partials/transactions-view.adoc
#	portx/modules/ROOT/pages/_partials/transmissions-view.adoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants