docs: Add instructions for using Spring Boot prior to version 2.7#674
Merged
bednar merged 2 commits intoinfluxdata:masterfrom Jan 29, 2024
Merged
docs: Add instructions for using Spring Boot prior to version 2.7#674bednar merged 2 commits intoinfluxdata:masterfrom
bednar merged 2 commits intoinfluxdata:masterfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #674 +/- ##
=========================================
Coverage 88.35% 88.35%
+ Complexity 779 777 -2
=========================================
Files 173 173
Lines 7078 7078
Branches 393 393
=========================================
Hits 6254 6254
Misses 699 699
Partials 125 125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bednar
approved these changes
Jan 29, 2024
Contributor
bednar
left a comment
There was a problem hiding this comment.
@shengbinxu thanks for your PR!
LGTM 🚀
Just for your information, PR #673 in the influxdb-client-java repository introduces support for Spring Boot 3. Consequently, the newest version of the client will no longer be compatible with Spring Boot 2.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Proposed Changes
When I introduced the influxdb-spring dependency into my Spring Boot 2.3 project, auto-configuration did not take effect, requiring additional code to be added. As a result, I updated the readme to provide instructions.
In the Maven repository influxdb-spring, the dependency for micrometer-registry-influx has already been added. Consequently, developers using influxdb-spring no longer need to manually import the micrometer-registry-influx dependency. Due to package conflicts, the
spring-boot-actuatormay have relied on an earlier version of themicrometer-core. Therefore, it is necessary to specify a higher version here.Checklist
mvn testcompletes successfully