This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Added batch option for write_points #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@manugarri awesome, thanks! |
toddboom
added a commit
that referenced
this pull request
Apr 18, 2014
Added batch option for write_points
Contributor
Author
|
:) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for a batched write operation.
I was noticing that, when I was trying to push many points at once, I was getting connection Errors.
I added a batch_size parameter to the client.write_points function that creates a generator to split the points into sets of points that then are sent to the write_points_with_precision function.