Skip to content

Bootstrap: introduce ecosystem parameters#153

Open
gmelikov wants to merge 1 commit intomasterfrom
eco
Open

Bootstrap: introduce ecosystem parameters#153
gmelikov wants to merge 1 commit intomasterfrom
eco

Conversation

@gmelikov
Copy link
Copy Markdown
Member

@gmelikov gmelikov commented Apr 8, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces functionality to register stands within the Genesis ecosystem, adding new CLI options for ecosystem configuration and token management. My feedback highlights that returning hardcoded fallback strings for stand credentials is misleading and potentially dangerous; these should be replaced with None or proper exception handling. Additionally, the interactive prompt for the organization token within the bootstrap flow may negatively impact non-interactive or automated environments, and I recommend evaluating a more robust approach for token validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant