Fixed to let Map instance handle default center and zoom if not defined#125
Open
m4rx wants to merge 1 commit intoinfusion-code:masterfrom
Open
Fixed to let Map instance handle default center and zoom if not defined#125m4rx wants to merge 1 commit intoinfusion-code:masterfrom
m4rx wants to merge 1 commit intoinfusion-code:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple fix that lets
const map = new Microsoft.Maps.Map(el, o);to set default center and zoom if those values are not provided in options.In current implementation undefined is treated as null and private values of _latitude, _longitude and _zoom are set. Those values are 0.