Merged
Conversation
Three new embedded skills for AI-powered code review: - code-review: Script-backed skill with code_review_diff and code_review_file tools. Supports GitHub PR URLs and local git diffs with Anthropic/OpenAI routing, large diff handling, untracked file inclusion, and custom org standards via .forge-review/ directory. - code-review-standards: Standards discovery and initialization skill with templates for config.yaml, ignore patterns, and language-specific rules (Go, Python, TypeScript, security, testing). - code-review-github: PR workflow orchestration skill for listing PRs, posting inline comments, applying labels, and guarded auto-merge. Also fixes a bug in runner.go where OneOf env vars were not passed through to the SkillCommandExecutor, causing skills using one_of requirements (like ANTHROPIC_API_KEY/OPENAI_API_KEY) to fail at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code_review_diffandcode_review_filetools. Supports GitHub PR URLs and local git diffs, Anthropic/OpenAI LLM routing, large diff detection (returns file list instead of silent truncation), untracked file inclusion,~path expansion, org standards via.forge-review/, and pre-flight scope check guidance for the agent..forge-review/configuration. Includes templates forconfig.yaml,.forge-review-ignore, and language-specific standards (Go, Python, TypeScript, security, testing, general).REVIEW_AUTO_MERGEopt-in.runner.gowas not passingOneOfenv vars toSkillCommandExecutor, causing skills withone_ofrequirements (e.g.,ANTHROPIC_API_KEY/OPENAI_API_KEY) to silently fail at runtime.Test plan
go build ./...on forge-cli — confirms go:embed captures new skill directoriesgo test ./...on forge-skills — all 8 packages pass, registry test updated for 8 skillschmod +xon both.shfiles)eval,curl|sh,rm -rf,chmod 777, or hardcoded secrets in scriptscode-review-diff.shwith local repo (diff acquisition, truncation, API routing)