Way to record the replays of the training#29
Open
mateusmatiazzi wants to merge 3 commits intoinoryy:masterfrom
Open
Way to record the replays of the training#29mateusmatiazzi wants to merge 3 commits intoinoryy:masterfrom
mateusmatiazzi wants to merge 3 commits intoinoryy:masterfrom
Conversation
Addition of flags --replay and --replay_dir to save the replays of th…
inoryy
reviewed
Apr 22, 2019
|
|
||
| env_cls = rvr.envs.GymEnv if '-v' in args.env else rvr.envs.SC2Env | ||
| env = env_cls(args.env, args.render, max_ep_len=args.max_ep_len) | ||
| env = env_cls(args.env, args.render, |
Owner
There was a problem hiding this comment.
This would break support for non-sc2 environments.
Can you add a general-purpose flag similar to render to base env class (e.g. call it monitor)? Simply ignore it in other envs for now.
inoryy
requested changes
Apr 22, 2019
Owner
inoryy
left a comment
inoryy
left a comment
There was a problem hiding this comment.
Thanks! Looks good except for the minor compatibility issue with other envs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just changed some parameters to utilize the record function of Pysc2. I also changed the ReadMe to show how the new flags works.