Needs error handling when trying to use WebID on a server that is offline

[megoth]

I've been using https://dev-generator.inrupt.com to test out functionality, and now that my local server is offline, it fails badly.

We should implement better error handling for these scenarios (albeit rare, they will happen).

[michielbdejong]

Triaged for when?

[Eliamar]

The fix was deployed here: https://develop.generator.inrupt.com - this url: https://dev-generator.inrupt.com is now deprecated. The spinner is no longer present on each screen change and a toastr notification is being displayed for error handling.

[michielbdejong]

@Eliamar you are right that now the spinner is no longer shown, but I think the complaint was not about the presence of a spinner, but rather that no feedback like "invalid webid" is shown.

Now when I click 'log in' with an invalid webid, the error is only logged to the console, not shown to the user:

cc @james-martin-jd

[michielbdejong]

This seems related to https://github.com/inrupt/solid-react-components/blob/develop/src/lib/components/ProviderLogin/provider-login.container.js#L75 maybe? I'm trying to debug this locally but having some trouble setting up my dev env for this repo, due to #137

[michielbdejong]

Fixing this in #142

[michielbdejong]

@megoth apparently this was already fixed but not deployed yet, but James just deployed to develop and I think this issue can be closed now, can you try now on https://develop.generator.inrupt.com/ ?

[brownhoward]

If a user attempts to log into the SDK (https://develop.generator.inrupt.com) while the server is offline, a generic Something is wrong, please try again... message is displayed as the SDK cannot know exactly what happens.

This update will be included in the next release.

[james-martin-jd]

@michielbdejong Also, to add to this, as a rule we're not closing issues until they are resolved on master. Develop branch is great, but can be unstable as we develop new things. It is a dev branch after all!

Once the develop branch is merged with master it is deployed to https://generator.inrupt.com which we consider to be our "prod" server.