Skip to content

Conversation

@jeswr
Copy link
Contributor

@jeswr jeswr commented Jul 14, 2023

Closes #1815
Closes #3001
Closes #3052

@jeswr jeswr requested a review from a team as a code owner July 14, 2023 01:22
@jeswr jeswr temporarily deployed to ESS PodSpaces July 14, 2023 01:23 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS Dev-2-2 July 14, 2023 01:23 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces July 14, 2023 01:23 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces July 14, 2023 01:23 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces July 14, 2023 01:23 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS Dev-2-2 July 14, 2023 01:23 — with GitHub Actions Inactive
{
"name": "test-app",
"version": "0.1.0",
"version": "1.17.0",
Copy link
Contributor

@chelseapinka chelseapinka Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was it intentional to version of the test-app this time, when it looks like it hasnt been bumped with previous releases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first release since moving to npm workspaces and the app was added to the workspace as part of that; so lerna versioned it.

This doesn't really matter because the manifest sets it as a private package so a release of it will not be made.

Copy link
Contributor

@chelseapinka chelseapinka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeswr jeswr merged commit 0f5275f into main Jul 14, 2023
@jeswr jeswr deleted the release/1.17.0 branch July 14, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot build with versions >1.13.4 ESM distro for @inrupt/solid-client-authn-browser import fails with esbuild

3 participants