JCL-279: Cache abstraction with Guava and Caffeine implementations #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timea-solid
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
timea-solid
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
timea-solid
approved these changes
Apr 11, 2023
Contributor
timea-solid
left a comment
timea-solid
left a comment
There was a problem hiding this comment.
Interesting.
Elegant implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a cache abstraction to the client libraries along with two implementations.
The new interfaces are:
com.inrupt.client.ClientCache- A generalizable cache abstraction with::get,::putand::invalidatemethodscom.inrupt.client.spi.CacheBuilderService- A generalizable cache builder with a method defining the size and retention durationThere are two new modules that implement these interfaces:
inrupt-client-caffeine) - this implementation is reportedly faster than guava and has some nice features that we will want to use laterinrupt-client-guava) - this implementation is widely used and will also work on AndroidThere is also a no-op implementation for cases where no cache support is desired. The no-op implementation is the default if no other service is registered, which also gives the code backwards compatibility.
This code is integrated into the OpenID, UMA and AccessGrant modules for handling metadata caching.