Skip to content

JCL-340: Pluralize getter methods in the accessgrant module #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acoburn merged 1 commit into from
May 17, 2023
Merged

JCL-340: Pluralize getter methods in the accessgrant module #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions access-grant/src/main/java/com/inrupt/client/accessgrant/AccessGrant.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,11 +231,22 @@ public URI getIdentifier() {
* Get the purposes of the access grant.
*
* @return the access grant purposes
* @deprecated as of Beta3, please use the {@link #getPurposes()} method
*/
@Deprecated
public Set<String> getPurpose() {
return purposes;
}

/**
* Get the purposes of the access grant.
*
* @return the access grant purposes
*/
public Set<String> getPurposes() {
return purposes;
}

/**
* Get the resources associated with the access grant.
*
Expand Down
2 changes: 2 additions & 0 deletions access-grant/src/test/java/com/inrupt/client/accessgrant/AccessGrantClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ void testIssueGrant() {
assertEquals(expiration, grant.getExpiration());
assertEquals(baseUri, grant.getIssuer());
assertEquals(purposes, grant.getPurpose());
assertEquals(purposes, grant.getPurposes());
assertEquals(resources, grant.getResources());
}

Expand Down Expand Up @@ -250,6 +251,7 @@ void testIssueRequest() {
assertEquals(expiration, request.getExpiration());
assertEquals(baseUri, request.getIssuer());
assertEquals(purposes, request.getPurpose());
assertEquals(purposes, request.getPurposes());
assertEquals(resources, request.getResources());
}

Expand Down
2 changes: 2 additions & 0 deletions access-grant/src/test/java/com/inrupt/client/accessgrant/AccessGrantTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ void testReadAccessGrant() throws IOException {
assertEquals(URI.create("https://accessgrant.example/credential/5c6060ad-2f16-4bc1-b022-dffb46bff626"),
grant.getIdentifier());
assertEquals(Collections.singleton("https://purpose.example/Purpose1"), grant.getPurpose());
assertEquals(Collections.singleton("https://purpose.example/Purpose1"), grant.getPurposes());
assertEquals(Collections.singleton(
URI.create("https://storage.example/e973cc3d-5c28-4a10-98c5-e40079289358/")),
grant.getResources());
Expand Down Expand Up @@ -88,6 +89,7 @@ void testReadAccessGrantSingletons() throws IOException {
assertEquals(URI.create("https://accessgrant.example/credential/5c6060ad-2f16-4bc1-b022-dffb46bff626"),
grant.getIdentifier());
assertEquals(Collections.singleton("https://purpose.example/Purpose1"), grant.getPurpose());
assertEquals(Collections.singleton("https://purpose.example/Purpose1"), grant.getPurposes());
assertEquals(Collections.singleton(
URI.create("https://storage.example/e973cc3d-5c28-4a10-98c5-e40079289358/")),
grant.getResources());
Expand Down