feat(env-helper): adding new test-env support package #1749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NSeydoux
approved these changes
Nov 15, 2022
| session = await getAuthenticatedSession(env); | ||
| sessionResource = `${env.pod}${sessionResourcePrefix}${session.info.sessionId}`; | ||
| pod = await getPodRoot(session); | ||
| sessionResource = `${pod}${sessionResourcePrefix}${session.info.sessionId}`; |
Contributor
There was a problem hiding this comment.
@NSeydoux @chelseapinka something we'll want to be very careful of in the future is making sure we construct IRIs properly with new URL it's not clear that pod has a trailing slash
Contributor
There was a problem hiding this comment.
Ah good point I missed that
| cwd: "../testApp", | ||
| command: "npm run dev", | ||
| // cwd: "./e2e/browser/testApp/", | ||
| command: "cd ./e2e/browser/testApp/ && npm run dev", |
Contributor
There was a problem hiding this comment.
@chelseapinka did cwd work here, or was cd in the command better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding @inrupt-test-env-helper package.
Goal of package is to replace redundant code with a reusable and extendable module for inrupts' packages.
Testing:
Unit test cases were erring for the main code branch.
Checklist
index.ts, if applicable..tsfiles) are listed in theexportsfield inpackage.json, if applicable..tsfiles) are listed in thetypedocOptions.entryPointsfield intsconfig.json, if applicable.