feat: Add getWebIdDataset method #1761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
VirginiaBalseiro
force-pushed
the
feat/get-webid-dataset
branch
from
9ef924b to
3331220
Compare
ThisIsMissEm
approved these changes
Nov 18, 2022
Contributor
ThisIsMissEm
left a comment
ThisIsMissEm
left a comment
There was a problem hiding this comment.
A few small changes, but otherwise, great work!
| const profileContent = buildThing({ url: webId }).addIri( | ||
| rdf.type, | ||
| foaf.Agent | ||
| ); |
| >; | ||
| }; | ||
| mockedUnauthFetch.mockRejectedValueOnce(new Error("error")); | ||
| await expect(getWebIdDataset(MOCK_WEBID)).rejects.toThrow("error"); |
Contributor
There was a problem hiding this comment.
Might be good to make the error message something like Fetch Failed 500 internal server error just so the code can't be satisfied by just doing new Error("error") or something — i.e., swallowing the error
NSeydoux
force-pushed
the
feat/get-webid-dataset
branch
from
3331220 to
3431741
Compare
Co-authored-by: Emelia Smith <ThisIsMissEm@users.noreply.github.com>
Co-authored-by: Emelia Smith <ThisIsMissEm@users.noreply.github.com>
NSeydoux
force-pushed
the
feat/get-webid-dataset
branch
from
b139653 to
e7ef9ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add getWebIdDataset function
Checklist
index.ts, if applicable..tsfiles) are listed in theexportsfield inpackage.json, if applicable..tsfiles) are listed in thetypedocOptions.entryPointsfield intsconfig.json, if applicable.