Disable running tests on MacOS #1785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MacOS tests have always been very flaky, and lately the browser-based tests on MacOS have been consistently failing. We haven't managed to reproduce the issues locally, so we'll disable running the tests on macOS until we have time to investigate properly. This probably means only revisiting when there is an actual issue on MacOS, but the likelyhood of a NodeJS or browser issue to be MacOS-specific is low enough that this is an acceptable risk.
NSeydoux
force-pushed
the
chore/-disable-macos-ci
branch
from
551d5c1 to
fb5ef21
Compare
ThisIsMissEm
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS tests have always been very flaky, and lately the browser-based tests on MacOS have been consistently failing. We haven't managed to reproduce the issues locally, so we'll disable running the tests on macOS until we have time to investigate properly. This probably means only revisiting when there is an actual issue on MacOS, but the likelyhood of a NodeJS or browser issue to be MacOS-specific is low enough that this is an acceptable risk.