chore: fix linting of test-app and remove webkit from e2e testing #1798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, autogenerated files shouldn't be being linted or modified.
ThisIsMissEm
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ThisIsMissEm
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
ThisIsMissEm
temporarily deployed
to
ESS Dev-Next
GitHub Actions
Inactive
ThisIsMissEm
commented
Dec 20, 2022
| // SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
| // | ||
| /// <reference types="next" /> | ||
| /// <reference types="next/image-types/global" /> |
Contributor
Author
There was a problem hiding this comment.
@chelseapinka @NSeydoux this file was broken by the recent changes, specifically, we need to exclude these files from license-header and linting/prettier.
| "lint": "npm run lint:check", | ||
| "lint:fix": "npm run lint:eslint -- --fix && npm run lint:prettier -- --write", | ||
| "lint:check": "npm run lint:eslint && npm run lint:prettier -- --check", | ||
| "lint:eslint": "eslint --config .eslintrc.js \"src/\" \"e2e/\" --ignore-pattern \"e2e/**/*js\"", |
Contributor
Author
There was a problem hiding this comment.
This is done with a new rule in .eslintignore and .prettierignore
| // process.env.CI === "true" ? "in CI" : "locally" | ||
| // }. Mozilla/5.0 (iPhone; CPU iPhone OS 13_5_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1.1 Mobile/15E148 Safari/604.1`, | ||
| // }, | ||
| // }, |
Contributor
Author
There was a problem hiding this comment.
Keeping it here just in case we want to get it back after ESS is fixed.
solid-akb
approved these changes
Dec 20, 2022
| *.snap | ||
| *.env | ||
| *.env.* | ||
| **/.next/ |
Contributor
There was a problem hiding this comment.
missing newline here, not a big deal
Contributor
Author
There was a problem hiding this comment.
eh, ooops, we can fix it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.