fix: move @types/rdfjs__dataset back to dependencies from devDependencies #1866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ThisIsMissEm
force-pushed
the
chore/fix-rdfjs-dataset-issue
branch
from
188bbef to
3e374db
Compare
ThisIsMissEm
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
ThisIsMissEm
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
ThisIsMissEm
temporarily deployed
to
ESS Dev-Next
GitHub Actions
Inactive
ThisIsMissEm
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
ThisIsMissEm
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
ThisIsMissEm
temporarily deployed
to
ESS Dev-Next
GitHub Actions
Inactive
chelseapinka
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary resolution to the typescript issues that people started noticing. We'd previously moved it to devDependencies because types should never be direct dependencies of npm packages in general, and we'd thought this was safe, with a minor caveat that our typedoc builds in the SDK repos broke, but we've since realised this actually affected all typescript projects, hence we're reverting the change and publishing a new release.