create unique text file for solid.for to write to, fix #50#55
create unique text file for solid.for to write to, fix #50#55yunjunz merged 3 commits intoinsarlab:mainfrom scottstanie:fix-text-file
Conversation
fix fortran compile error
Error: IMPLICIT statement at (1) cannot follow data declaration statement at (2)
use the text file argument
|
now that i've fixed the failing CIs, I'll confirm that it does seem to fix what I was running (which was 6 COMPASS runs at a time) note that i also got a warning, which can be a separate issue: |
yunjunz
left a comment
There was a problem hiding this comment.
Thank you @scottstanie, great idea to use the tempfile module! The PR looks pretty clean, I only have a few minor comments, could you take a look?
That's an existing warning from numpy, nothing to do with pysolid, you could safely ignore it. |
|
That's great news @scottstanie! I would like both if it's not too much to ask~ The current PR is a simpler change, as you said, I would like to have this in the commit history. |
|
that makes sense too! i'll rebase that other PR off of this one once it's merged in. |
Seems to fix the race condition which happens when multiple processes are running in the same directory that @vbrancat and I also saw, which I see was already opened in #50
I started on directly returning arrays from fortran but gave up on it. Maybe some day...